5afe / safe-react

Deprecated! New repo – https://github.com/safe-global/web-core
MIT License
332 stars 363 forks source link

xDai Report several issues #1483

Closed francovenica closed 4 years ago

francovenica commented 4 years ago

Safes used for testing: https://safe-team-xdai.staging.gnosisdev.com/app/#/safes/0x8B22bAf910E83a66FacF8539AFC125cBc026059b/balances https://safe-team-xdai.staging.gnosisdev.com/app/#/safes/0xB8d760a90a5ed54D3c2b3EFC231277e99188642A/balances

1 - Incoming tx of tokens different than xDai were not showing, or taking too long to arrive 2 - Balance of tokens that are not xDai are not showing image.png 3 - Opending a incomming tx would crash the page and show an error in console incoming tx open crash.png 4 - The 0xB8d760a90a5ed54D3c2b3EFC231277e99188642A safe got stuck rejecting a tx. It was approved, but is still in "awaiting confirmations". When I tried that I had an error of "You have reached your event rate limit for today." for the first time. After that I keeps seeing the error from time to time I repeated the proccess in a different safe and I was able to reject the tx, so the reject itself is working fine tx cancelation stuck.png rate limit error.png 5 - An error of gas estimation pop's up everytime you try to sign a tx of any kind: error gas estimation.png 6 - An error that doesn't happen in the dev env shows in the console when I cancel the tx in the MM prompt: image.png

Note: The "Safe creation" tx disappears sometimes from the tx table, but there are issues with that tx already reported in another ticket, so is not only about the xDai: #1488

francovenica commented 4 years ago

There is an rpc.xdaichain.com error that also shows up in the console from time to time, but it doesn't seems to be caused by any user interaction itself. image.png

francovenica commented 4 years ago

Trying the tx builder I took the address of a nifty token in xDai. The tx builder cannot load the ABI, but the Contract interaction form can do it, so it could be that is the Tx builder the one giving troubles.

The contract: 0xCF964c89f509a8c0Ac36391c5460dF94B91daba5

Loom video: https://www.loom.com/share/27f3fd38d1a645fab98cd8d6567d7f22

francovenica commented 4 years ago

Tried the WallectConnect App on the site Nifty.ink that works in xDai and has WC connection type I was able to connect to it, but trying to use the app it would tell me to switch networks, like if the safe app is not in the xdai network image.png

lukasschor commented 4 years ago

1-3 are critical for me 4 is also a issue on mainnet afaik. https://github.com/gnosis/safe-react/issues/1471 The others don't seem critical for me, so no must-fixes for a first version

dasanra commented 4 years ago

I think issue 1-3 were related to a backend bug, fixed by Uxio this morning. It's already on staging

Number 4 was related not only to issue https://github.com/gnosis/safe-react/issues/1471 but also to the one Mikhail was already fixing for Synthetix https://github.com/gnosis/safe-react/issues/1384

So now the fix is merged to xDai integration branch the transaction status seems correct

dasanra commented 4 years ago

@francovenica TX-Builder wasn't updated in the environment used for testing xDai. Now it should be fixed

tschubotz commented 4 years ago

I used the WalletConnect app on xdai with https://dex.staging.gnosisdev.com/wallet without any issues today!

Uxio0 commented 4 years ago

To complete a little more what @dasanra commented, 1 - 3 were related to the oracles not present on xDai network and the service trying to estimate the ether price of the tokens. It has been fixed ignoring the usd conversion for the tokens as there's no reliable way to get them and using DAIUSD for "ether" usd price.

francovenica commented 4 years ago

1 - Fixed 2 - Fixed 3 - Fixed 4 - Tx builder not recognizing addresses from xdai smart contracts was fixed The safe was able to recognize the network. Tried with https://dex.staging.gnosisdev.com/wallet

francovenica commented 4 years ago

The rest of the issues are in this new issue #1488 and #1490

tschubotz commented 4 years ago

If I understand the comments correctly, this one can be closed, right? Please reopen if necessary @francovenica