search

5afe / safe-react

Deprecated! New repo – https://github.com/safe-global/web-core
MIT License
332 stars 363 forks source link

Trezor and Ledger not working on Non ETH networks #1532

Closed francovenica closed 3 years ago

francovenica commented 4 years ago

Direct connections with trezor and ledger are not working in the Safe. You can: -Connect and see the tokens you have in that network -Sign off chain signatures

You cant: -Sign tx that requires paying a fee, so no safe creation or tx execution

Trying to create a safe with ledger or trezor image.png

Trying to sign and execute a tx will prompt the notification of "Please sign the tx, but it never pops up on the device itself. The same happens with trezor and ledger image.png

Noticed that is reading properly that I have EWT tokens in the trezor and leger devices, even if they are being labeled as ETH image.png

tschubotz commented 4 years ago

@francovenica Did you use the Volta testnet app on the Ledger or the Ethereum app?

I just tried on-chain signing / executing with the Volta textnet app (https://energyweb.atlassian.net/wiki/spaces/EWF/pages/1075052624/Energy+Web+Wallet)

And I get different errors: image.png

tschubotz commented 4 years ago

I also just tried with https://wallet.energyweb.org/. There I am able to make contract calls with the ledger and the Volta app.

tschubotz commented 4 years ago

@francovenica @dasanra could it be that we need to integrate EWC/Volta into onboard.js first, similar to https://github.com/blocknative/onboard/issues/384 to resolve the issue?

tschubotz commented 4 years ago

For xDai, there is no Ledger app, hence I think it does not work with the direct Ledger integration. Could this be?

matextrem commented 3 years ago

This issue is blocked by https://github.com/blocknative/onboard/pull/457

tschubotz commented 3 years ago

We are still blocked by the onboard.js PR which is quite a bummer. I would close this issue then for the time being since it's not on us.