5afe / safe-react

Deprecated! New repo – https://github.com/safe-global/web-core
MIT License
332 stars 363 forks source link

Add a EIP-1559 feature flag #3121

Closed katspaugh closed 2 years ago

katspaugh commented 2 years ago

Overview

Currently, we have the list of EIP-1559-capable chains hardcoded.

We need to use the config service instead.

Requirements

katspaugh commented 2 years ago

cc @fmrsabino

fmrsabino commented 2 years ago

Feature EIP1559 was added to both staging and production for the following networks:

Staging:

https://safe-config.staging.gnosisdev.com/api/v1/chains/1/ https://safe-config.staging.gnosisdev.com/api/v1/chains/4/

Production:

https://safe-config.gnosis.io/api/v1/chains/1/ https://safe-config.gnosis.io/api/v1/chains/4/ https://safe-config.gnosis.io/api/v1/chains/100/

iamacook commented 2 years ago

Thanks @fmrsabino, I'll move this to the gateway so as to add the types.

katspaugh commented 2 years ago

@iamacook this was meant for safe-react, please don't transfer issues at will.

iamacook commented 2 years ago

@katspaugh, apologies. We need not forget to add it to the types, nonetheless.

fmrsabino commented 2 years ago

Thanks @fmrsabino, I'll move this to the gateway so as to add the types.

@iamacook this was meant for safe-react, please don't transfer issues at will.

Just to clarify, there are no types for features on the Safe Client Gateway. No action should be required by the backend team for this

iamacook commented 2 years ago

@fmrsabino, we have our own gateway types. The above would need to be added to our FEATURES enum.

rmeissner commented 2 years ago

You can access this via the client gateway: e.g. https://safe-client.gnosis.io/v1/chains/100/