5afe / safe-react

Deprecated! New repo – https://github.com/safe-global/web-core
MIT License
332 stars 363 forks source link

Fix correct linking for token allocation #4111

Closed dasanra closed 1 year ago

dasanra commented 1 year ago

What it solves

Link from allocation widget in header to open the Safe App is malformed, missing /app and reloads the whole web. Somehow in web is working but the desktop app is not able to resolve the link.

How this PR fixes it

Use react-router to navigate to the correct route

How to test it

Check that in prod the /app is missing when hovering the allocation widget in the header Styles should be exactly the same. Link should correctly redirect to the Safe App

In the desktop app without this fix, app is not correctly redirected. If we use a normal link the current Wallet is disconnected

github-actions[bot] commented 1 year ago

CLA Assistant Lite All Contributors have signed the CLA.

github-actions[bot] commented 1 year ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3395483432


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AppLayout/Header/components/SafeTokenWidget/index.tsx 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/logic/safe/hooks/useOwnerSafes.ts 1 95.83%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 3321854842: -0.006%
Covered Lines: 4777
Relevant Lines: 10403

💛 - Coveralls