5afe / safe-react

Deprecated! New repo – https://github.com/safe-global/web-core
MIT License
332 stars 364 forks source link

Allow empty string to be passed #4136

Open GopherJ opened 1 year ago

GopherJ commented 1 year ago

I'm not sure if this is the correct place to raise this issue. You may give me the correct repo if this isn't.

While using safe to manage a timelock, I encountered an issue.

Safe dont allow users to input empty string.

When the type is bytes we can still enter 0x, but when the type is string, safe requires it to be non-empty, but there is of course a need to pass empty string. For example in aave's timelock contract the signature parameter can be empty string

To solve this currently I have to use Custom Data

katspaugh commented 1 year ago

Thanks for the report @GopherJ!

Could you post a screenshot of the problem?

katspaugh commented 1 year ago

I’m asking because it seems you’re talking about the Transaction Builder app, which is a separate repo/project.

cc @dasanra