5afe / safe-react

Deprecated! New repo – https://github.com/safe-global/web-core
MIT License
332 stars 363 forks source link

Release 3.33.6 #4147

Closed katspaugh closed 1 year ago

katspaugh commented 1 year ago

A small fix to hide internal links on the Export page.

Can be tested on https://safe-web.dev.5afe.dev/app/export

All other URLs, e.g. https://safe-web.dev.5afe.dev/app/welcome, should redirect to the new app.

github-actions[bot] commented 1 year ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 0 N/A

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4007157483


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/export/Export.tsx 0 7 0.0%
<!-- Total: 1 8 12.5% -->
Files with Coverage Reduction New Missed Lines %
src/routes/export/Export.tsx 1 0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 3874450554: -0.03%
Covered Lines: 4779
Relevant Lines: 10428

💛 - Coveralls
francovenica commented 1 year ago

LGTM The links in the upper left corner takes to the new app The export button looks fine You can switch networks if you are connected to MM in another network, but that doens't affect the use of the export functionality.

A comparison between the current safe-react prod and this PR image image