5afe / safe-support

6 stars 2 forks source link

[ARB] Balance not updating/moving between wallets despite the transaction showing as successful #364

Open joanpan opened 9 months ago

joanpan commented 9 months ago

Issue Category

Safe loading issue, doesnt load on any interface

What happened?

User successfully sent two transactions 0.035 ETH each even though their initial balance was only 0.035 ETH. https://app.safe.global/transactions/history?safe=arb1:0xAB487ac3D49a39FD4927d8381736Ea51da4b7a51 image

Transaction was showing as successful but safe balance was not deducted:

First transaction: https://arbiscan.io/tx/0x3e8312339142b301e4e17aa5852d78911983aa53af33dcfe0ef837ec69b044cc State change (no difference) image

Second transaction: https://arbiscan.io/tx/0xecf71fcc5a208ca5622eca4b05b9b8579e917ae3fab38afb50aeb741813c642b State change (no difference) image

Receiving wallet: https://arbiscan.io/address/0xC803223a8120AC77ee9694a11d42E0207987b4f9#internaltx image

Date and time this happened or you first noticed this issue

04-01-2024

Network

Arbitrum

Safe Address

0xAB487ac3D49a39FD4927d8381736Ea51da4b7a51

Token Address

No response

Token Type

None

Transactions

No response

joanpan commented 9 months ago

The user was able to initiate another transaction, and it looks like the safe balance got deducted now. Not sure why the first two transactions went through fine without deducting anything

https://arbiscan.io/tx/0xb232928dd989da17f7248db724d14b743269397ac9a0336e5bb780c3386c349a image

JagoFigueroa commented 9 months ago

Hi there! Looks like a temporary issue during this evening. I have tried with a couple of my test safes on arbitrum and balances look to be updating as expected as well now so I will go ahead and close this if that is okay.

Cheers!

MicahZoltu commented 9 months ago

@JagoFigueroa What sort of temporary issue would result in the UI attaching ETH to SAFE transactions that are supposed to be sending ETH? Is this something where the user can accidentally attach ETH to a SAFE transaction?

JagoFigueroa commented 9 months ago

My bad there, was a bit too quick to reach a conclusion given some issues that we had this evening on our end, reopened it 😅

I am checking with the devs, we will post more details on what we think happened shortly 😄

DaniSomoza commented 9 months ago

The issue you're encountering with the those Safe transaction involves the execTransaction method. Specifically, a user is attempting to transfer 0.035 ETH to the same EOA that is initiating the transaction. However, the problem arises because the transaction executing the execTransaction method has a value set to the same amount of 0.035 ETH, when ideally, it should be zero.

As a result, although the transaction completes successfully, the resulting balance remains unchanged. This is because, on one hand, you are sending out ETH, and on the other, the same amount is being returned to the account.

This can be confusing as it appears as a successful transaction, yet the account balance does not reflect the expected decrease from sending ETH.

In the first 2 transactions yo can see the value field set as 0.035 ETH:

 https://arbiscan.io/tx/0x3e8312339142b301e4e17aa5852d78911983aa53af33dcfe0ef837ec69b044cc

Captura de pantalla 2024-01-04 a las 12 19 56

And in the last transaction the value is correctly set to 0:

https://arbiscan.io/tx/0xb232928dd989da17f7248db724d14b743269397ac9a0336e5bb780c3386c349a

Captura de pantalla 2024-01-04 a las 12 27 22

More Details:

https://dashboard.tenderly.co/tx/arbitrum/0x3e8312339142b301e4e17aa5852d78911983aa53af33dcfe0ef837ec69b044cc

CC: @MicahZoltu @joanpan

MicahZoltu commented 9 months ago

@DaniSomoza That is the same conclusion I came to, but what is confusing to me is how the user managed to construct such a transaction through the SAFE UI?

DaniSomoza commented 9 months ago

@MicahZoltu, that's a good question.

I attempted to reproduce the issue using the Safe UI, but everything worked fine on my end.

Is it possible that the user is not utilizing the Safe UI to build this transaction? Could they be using a custom script instead?

CindyLo0 commented 9 months ago

Hi @DaniSomoza, we will check with the user and will update here. Thank you.

CindyLo0 commented 9 months ago

Hi @DaniSomoza, the user said they only used the Safe UI to send, no custom script was used. They were using the Safe mobile app for Android.

JagoFigueroa commented 9 months ago

We will share this with the mobile team. Thanks @CindyLo0!

Claire-serveth commented 2 weeks ago

Sorry, I have to close this issue to find the closed intercom ticket: https://app.eu.intercom.com/a/inbox/pynbtguw/inbox/shared/all/conversation/212174700005123?view=List