search

5afe / safe

Repo to collect Gnosis Safe ideas, feature requests and epics in order to make the roadmap more clear
23 stars 4 forks source link

ENS integration #45

Closed tschubotz closed 5 years ago

tschubotz commented 5 years ago

see epic #3

posthnikova commented 5 years ago

There is one question about "Confirm" button on Android. I noticed it's in the nav bar only in Address book, other screens with input fields have primary button at the bottom. I have it in the nav bar when ENS name is entered because of Address book (https://zpl.io/a3RLxm1). I wonder if we should keep it consistent everywhere.

This is not a big change so I uploaded screens to zeplin anyway.

iOS: https://app.zeplin.io/project/5c49ce9866e3b3bee966f431/dashboard?seid=5d4ac451859f2851f96bfcd1

Android: https://app.zeplin.io/project/5af063c9b4dc859b6bdaf897/dashboard?seid=5d4ac4e86754d79b304c487a

tschubotz commented 5 years ago

Thanks for uploading the screens!

https://zpl.io/V0w8jdl -> I would also do the reverse lookup on address book entry view screens. What do you think?

Regarding your question on confirm buttons in the navbar vs on the bottom. Good questions. I think the Android phone address book has it in a similar fashion, that's why we put it in the navbar, initially.

posthnikova commented 5 years ago

I would also do the reverse lookup on address book entry view screens.

@tschubotz What benefits does reverse lookup have here? ENS won't show while choosing this contact from address book because you choose from this list https://zpl.io/aMPZ0vr. One case I see where this could be useful is to go to Address book entry, copy ENS name, go to Send screen, paste ENS name into input field. I'm not sure if we should optimise for this case. This is a roundabout way of sending funds.

I checked Android and it has buttons on top in Contacts http://joxi.net/gmvYdeZfqRv8Lr. I think buttons at the bottom are easier to tap. In case of screens with keyboards I would prefer buttons on top because keyboard occupies a lot of space.

tschubotz commented 5 years ago

@tschubotz What benefits does reverse lookup have here?

Same reason like on the receive screen: (1) Double check that the address is correct when it resolves to the correct name, (2) copy to share with the name is nicer than with the address (3) when someone scans, they can easier check if it's the right thing.

I think buttons at the bottom are easier to tap. In case of screens with keyboards I would prefer buttons on top because keyboard occupies a lot of space.

Yes. I think in flows where the confirm button is an important CTA to get the users through the flow, we use the big buttons. On the address book screens it's more important to preserve vertical space imo.

posthnikova commented 5 years ago

Same reason like on the receive screen: (1) Double check that the address is correct when it resolves to the correct name, (2) copy to share with the name is nicer than with the address (3) when someone scans, they can easier check if it's the right thing.

@tschubotz I'm not against it so here is the missing "View entry" with ENS: https://zpl.io/V0w8oMo

On the address book screens it's more important to preserve vertical space imo.

👍

lukasschor commented 5 years ago

Screens added to Lokalise