5afe / svalinn-kotlin

🛡️❄️️ Kotlin libraries for Ethereum based Android development
MIT License
31 stars 3 forks source link

Remove block from estimate request; Improve error messages #10

Closed rmeissner closed 6 years ago

rmeissner commented 6 years ago

Changes proposed in this pull request:

@gnosis/mobile-devs

codecov-io commented 6 years ago

Codecov Report

Merging #10 into master will increase coverage by 0.13%. The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
+ Coverage     65.85%   65.99%   +0.13%     
  Complexity      142      142              
============================================
  Files            48       48              
  Lines          1031     1035       +4     
  Branches        183      181       -2     
============================================
+ Hits            679      683       +4     
+ Misses          266      265       -1     
- Partials         86       87       +1
Impacted Files Coverage Δ Complexity Δ
.../java/pm/gnosis/ethereum/rpc/models/RpcRequests.kt 88.4% <0%> (-0.17%) 0 <0> (ø)
...va/pm/gnosis/ethereum/rpc/RpcEthereumRepository.kt 93.87% <100%> (+3.13%) 7 <0> (ø) :arrow_down:
...main/java/pm/gnosis/ethereum/EthereumRepository.kt 65.78% <80%> (+5.07%) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cfbb8f...8d4f5ae. Read the comment docs.