search

5afe / svalinn-kotlin

🛡️❄️️ Kotlin libraries for Ethereum based Android development
MIT License
31 stars 3 forks source link

Added block parameter #11

Closed rmeissner closed 6 years ago

rmeissner commented 6 years ago

Changes proposed in this pull request: Before we used latest as the default block parameter (except for getTransactionCount where we used pending). Now pending is the default block parameter for all calls and it is possible to specify the block (pending, latest, earliest or a block number).

@gnosis/mobile-devs

codecov-io commented 6 years ago

Codecov Report

Merging #11 into master will increase coverage by 0.16%. The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
+ Coverage     65.99%   66.15%   +0.16%     
  Complexity      142      142              
============================================
  Files            48       48              
  Lines          1035     1052      +17     
  Branches        181      185       +4     
============================================
+ Hits            683      696      +13     
- Misses          265      268       +3     
- Partials         87       88       +1
Impacted Files Coverage Δ Complexity Δ
...main/java/pm/gnosis/ethereum/EthereumRepository.kt 68% <72.22%> (+2.21%) 0 <0> (ø) :arrow_down:
.../java/pm/gnosis/ethereum/rpc/models/RpcRequests.kt 87.83% <87.5%> (-0.57%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b62c3f2...7a1d834. Read the comment docs.