search

5afe / svalinn-kotlin

πŸ›‘οΈβ„οΈοΈ Kotlin libraries for Ethereum based Android development
MIT License
31 stars 3 forks source link

WA-217: Use Solidity types from Bivrost #13

Closed fmrsabino closed 6 years ago

fmrsabino commented 6 years ago

Changes proposed in this pull request:

@gnosis/mobile-devs

fmrsabino commented 6 years ago

To merge only after Bivrost release

codecov-io commented 6 years ago

Codecov Report

Merging #13 into master will decrease coverage by 0.54%. The diff coverage is 55.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #13      +/-   ##
===========================================
- Coverage     66.15%   65.6%   -0.55%     
+ Complexity      142     140       -2     
===========================================
  Files            48      49       +1     
  Lines          1052    1041      -11     
  Branches        185     177       -8     
===========================================
- Hits            696     683      -13     
- Misses          268     273       +5     
+ Partials         88      85       -3
Impacted Files Coverage Ξ” Complexity Ξ”
...va/pm/gnosis/ethereum/rpc/RpcEthereumRepository.kt 93.87% <ΓΈ> (ΓΈ) 7 <0> (ΓΈ) :arrow_down:
.../main/java/pm/gnosis/blockies/BlockiesImageView.kt 0% <ΓΈ> (ΓΈ) 0 <0> (ΓΈ) :arrow_down:
utils/src/main/java/pm/gnosis/utils/Extensions.kt 95.74% <0%> (-2.09%) 0 <0> (ΓΈ)
...accounts/repositories/impls/models/db/AccountDb.kt 75% <0%> (ΓΈ) 1 <0> (ΓΈ) :arrow_down:
...tories/impls/models/db/SolidityAddressConverter.kt 0% <0%> (ΓΈ) 0 <0> (?)
.../pm/gnosis/svalinn/accounts/base/models/Account.kt 0% <0%> (ΓΈ) 0 <0> (ΓΈ) :arrow_down:
...ckies/src/main/java/pm/gnosis/blockies/Blockies.kt 98.24% <100%> (+1.69%) 5 <0> (ΓΈ) :arrow_down:
erc67/src/main/java/pm/gnosis/erc67/ERC67Parser.kt 92.59% <100%> (ΓΈ) 0 <0> (ΓΈ) :arrow_down:
...is/svalinn/accounts/utils/TransactionExtensions.kt 75% <100%> (ΓΈ) 0 <0> (ΓΈ) :arrow_down:
.../repositories/impls/KethereumAccountsRepository.kt 37.14% <33.33%> (+2.85%) 5 <0> (ΓΈ) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 6e6ee37...86c7c11. Read the comment docs.