Remove Dagger dependency

[fmrsabino]

Dagger modules were being provided which may conflict with modules in other projects and with different Dagger version.

@gnosis/mobile-devs

[rmeissner]

Can we add to the ReadMe how to create the instances we created in the modules?

e.g. Geth Key Store, Accounts Database, Bip39Generator, AesEncryptionManager, DefaultTickerRepository

Also on second thought, I do think it is really convenient to have the dagger stuff in the library and you can always decide to write your own module to provide the implementation.

What are the concrete disadvantages to have dagger dependencies in svalinn?

[fmrsabino]

In my opinion it is one less dependency provided and we are not tied to a specific solution for DI.

[rmeissner]

But you are not tied to it anyways, right? Proguard will also remove unused code. What are potential issues that could occur if we leave it in?

[codecov-io]

Codecov Report

Merging #15 into master will increase coverage by 0.28%. The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master      #15      +/-   ##
============================================
+ Coverage     65.74%   66.02%   +0.28%     
  Complexity      140      140              
============================================
  Files            49       45       -4     
  Lines          1051     1045       -6     
  Branches        180      180              
============================================
- Hits            691      690       -1     
+ Misses          273      268       -5     
  Partials         87       87

Impacted Files	Coverage Δ	Complexity Δ
...svalinn/security/impls/AndroidFingerprintHelper.kt	0% <0%> (ø)	0 <0> (?)
...ereum/rpc/retrofit/RetrofitEthereumRpcConnector.kt	100% <100%> (ø)	4 <1> (ø)	:arrow_down:
.../repositories/impls/KethereumAccountsRepository.kt	37.14% <100%> (ø)	5 <1> (ø)	:arrow_down:
...src/main/java/pm/gnosis/mnemonic/Bip39Generator.kt	86.95% <100%> (ø)	20 <1> (ø)	:arrow_down:
...sis/svalinn/security/impls/AesEncryptionManager.kt	77.67% <100%> (ø)	23 <1> (ø)	:arrow_down:
...va/pm/gnosis/ethereum/rpc/RpcEthereumRepository.kt	93.87% <100%> (ø)	7 <1> (ø)	:arrow_down:
crypto/src/main/java/pm/gnosis/crypto/KeyPair.kt	62.18% <0%> (-0.85%)	17% <0%> (ø)
...rc/main/java/pm/gnosis/crypto/LinuxSecureRandom.kt	0% <0%> (ø)	0% <0%> (ø)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6141bc...7f8839b. Read the comment docs.