5afe / svalinn-kotlin

🛡️❄️️ Kotlin libraries for Ethereum based Android development
MIT License
31 stars 3 forks source link

Recover Signature from Transactions which use Chain ID. Closes #17 #18

Closed fmrsabino closed 6 years ago

fmrsabino commented 6 years ago

Closes #17 .

Changes proposed in this pull request:

@gnosis/mobile-devs

codecov-io commented 6 years ago

Codecov Report

Merging #18 into master will increase coverage by 0.09%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #18      +/-   ##
==========================================
+ Coverage      65.9%    66%   +0.09%     
- Complexity      140    142       +2     
==========================================
  Files            45     45              
  Lines          1047   1053       +6     
  Branches        180    182       +2     
==========================================
+ Hits            690    695       +5     
  Misses          270    270              
- Partials         87     88       +1
Impacted Files Coverage Δ Complexity Δ
...m/gnosis/svalinn/accounts/base/models/Signature.kt 75% <85.71%> (+5%) 4 <0> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88b7d87...0496364. Read the comment docs.