5afe / svalinn-kotlin

🛡️❄️️ Kotlin libraries for Ethereum based Android development
MIT License
31 stars 3 forks source link

Make Result optional #24

Closed rmeissner closed 6 years ago

rmeissner commented 6 years ago

Changes proposed in this pull request:

@gnosis/mobile-devs

codecov-io commented 6 years ago

Codecov Report

Merging #24 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #24      +/-   ##
============================================
+ Coverage     66.58%   66.63%   +0.05%     
  Complexity      146      146              
============================================
  Files            48       48              
  Lines          1191     1193       +2     
  Branches        183      185       +2     
============================================
+ Hits            793      795       +2     
  Misses          310      310              
  Partials         88       88
Impacted Files Coverage Δ Complexity Δ
...ava/pm/gnosis/ethereum/rpc/models/JsonRpcResult.kt 78.37% <100%> (ø) 4 <1> (ø) :arrow_down:
.../java/pm/gnosis/ethereum/rpc/models/RpcRequests.kt 87.5% <100%> (+0.35%) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25a7bc4...d47a09b. Read the comment docs.