5afe / svalinn-kotlin

🛡️❄️️ Kotlin libraries for Ethereum based Android development
MIT License
31 stars 3 forks source link

Feature/#40 add moshi type adapters #44

Closed biafra23 closed 4 years ago

biafra23 commented 4 years ago

Closes #40 .

Changes proposed in this pull request:

At the moment these Adapters are not used in the gnosis-safe-android app. And the legacy app does not support the changes made in v0.11.0

@gnosis/mobile-devs

codecov-io commented 4 years ago

Codecov Report

Merging #44 into master will increase coverage by 0.17%. The diff coverage is 65.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #44      +/-   ##
============================================
+ Coverage     60.08%   60.25%   +0.17%     
  Complexity      154      154              
============================================
  Files            54       55       +1     
  Lines          1378     1394      +16     
  Branches        231      230       -1     
============================================
+ Hits            828      840      +12     
- Misses          433      436       +3     
- Partials        117      118       +1     
Impacted Files Coverage Δ Complexity Δ
...ava/pm/gnosis/common/adapter/moshi/TypeAdapters.kt 63.63% <63.63%> (ø) 0.00 <0.00> (?)
utils/src/main/java/pm/gnosis/utils/NumberUtils.kt 93.75% <100.00%> (+0.41%) 0.00 <0.00> (ø)
...m/gnosis/svalinn/accounts/base/models/Signature.kt 75.00% <0.00%> (-1.48%) 4.00% <0.00%> (ø%)
...sis/svalinn/security/impls/AesEncryptionManager.kt 73.94% <0.00%> (-0.22%) 24.00% <0.00%> (ø%)
...pto/src/main/java/pm/gnosis/crypto/utils/Curves.kt 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
...rc/main/java/pm/gnosis/crypto/LinuxSecureRandom.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...gnosis/svalinn/security/impls/AndroidKeyStorage.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09a420c...8cf6bd9. Read the comment docs.

jpalvarezl commented 4 years ago

LGTM