search

5argon / NotchSolution

A set of components and tools to solve notched/cutout phones layout problems for Unity.
http://exceed7.com/notch-solution
MIT License
672 stars 90 forks source link

Unity changed their device.json format #48

Open 5argon opened 4 years ago

5argon commented 4 years ago

Got no time to look at yet, not sure if we have to edit anything to be compatible with them or not. Quoted from my bug report :

Re: (Case 1194745) [Device Simulator] NullReferenceException is thrown when opening a device with json with no deviceinfo set

Hi,

Thanks for reporting the issue. We have fixed this problem and it should not appear in Device simulator 2.0.0-preview and above.

The device.json format has been changed in Device Simulator 2.0.0-preview. A new format is documented in https://docs.unity3d.com/Packages/com.unity.device-simulator@2.0/manual/device-format.html

The documentation contains an example of a minimal device, with only required fields set.

What is more, a detailed warning will be thrown in the console if device has missing info in the device.json file. If warnings are thrown for a device, this device will be ignored.

Please note that the minimum Unity version for Device Simulator 2.0.0-preview is now 2019.3.0f1.

Thanks, Lukaš Customer QA Team

https://docs.unity3d.com/Packages/com.unity.device-simulator@2.0/manual/device-format.html

tgaldi commented 2 years ago

I updated to 2019.4.37f1 and the latest DeviceSimulator preview package. Everything seemed to work fine, but I later deleted my Library folder and when the project rebuilt the SafePadding component no longer worked. Not sure if this is related, but something to watch out for...

Luckily I had a backup of the library, but definitely not a long term solution.