search

5balloons / laravel-smart-ads

Ads, Banners, Callout Manager and Auto Ad Inserter for Laravel
MIT License
298 stars 32 forks source link

Error on edit #4

Closed GeneratorEVil closed 1 year ago

GeneratorEVil commented 1 year ago

Undefined property: stdClass::$style (View: /vendor/5balloons/laravel-smart-ads/resources/views/smart-ad-manager/edit.blade.php)

  1. Add image banner
  2. Change auto insertion
  3. Try edit - error

In DB JSON [{"position": "afterbegin", "selector": "#banner-1-mid-en"}] Have not style param.

tushargugnani commented 1 year ago

@GeneratorEVil Will check this, thank you for posting.

GeneratorEVil commented 1 year ago

@GeneratorEVil Will check this, thank you for posting.

And when change banner's title , slug not updating

tushargugnani commented 1 year ago

@GeneratorEVil since slug is used to keep track of ad clicks, it's deliberately kept the same even if the title changes.

tushargugnani commented 1 year ago

Fixed in v1.2.6