Using styles xml - Githubissues

5calls / android

The Android App of 5 Calls

https://play.google.com/store/apps/details?id=org.a5calls.android.a5calls&rdid=org.a5calls.android.a5calls

MIT License

20 stars 8 forks source link

Using styles xml #112

Closed perlajarillo closed 5 years ago

perlajarillo commented 6 years ago

Related to #20: Make more use of styles.xml rather than formatting every view.

Making use of styles.xml rather than formatting every view.
Including dimen resources instead hardcoding them.

nickoneill commented 6 years ago

Thanks @perlajarillo! I'll find someone on the android side to review this shortly

perlajarillo commented 6 years ago

No problem @nickoneill! Please let me know if some changes are required.

dektar commented 6 years ago

Hi, I can take a look at this soon, hopefully this evening. Sorry for the delay -- I was unavailable this weekend!

perlajarillo commented 6 years ago

Hi @dektar , thank you for the feedback, I will work in the improvements.

perlajarillo commented 6 years ago

Hi @dektar . I have completed the changes you suggested. In my personal opinion you don't need to worry about the attributes that require APIs higher than the minimum API for now.

I have reviewed once more all the views but please let me know if I forgot something.

dektar commented 5 years ago

Thanks. Do you want to try to resolve the conflicts with the base branch?

perlajarillo commented 5 years ago

@dektar I resolved the conflicts. I thinks this PR is ready to go, but let me know if something else is required.