search

5calls / android

The Android App of 5 Calls
https://play.google.com/store/apps/details?id=org.a5calls.android.a5calls&rdid=org.a5calls.android.a5calls
MIT License
20 stars 8 forks source link

Not all outcome buttons display #117

Closed chadschultz closed 4 years ago

chadschultz commented 4 years ago

I recently started using 5 Calls, and ran into an issue on my Pixel 2 XL (Android 10). For some issues, only the "UNAVAILABLE" button would display. "LEFT VOICEMAIL" and "MAKE CONTACT" would not.

Here I am at the bottom of the screen, only able to show one button:

device-2020-06-05-190336

But if I turn the screen sideways, I see all the buttons:

device-2020-06-05-190240

Here's a different issue that doesn't have the problem - all three buttons show in portrait mode.

device-2020-06-05-190353

My guess is that it's based on exactly how tall the screen space is and how tall the content is, so it may be tricky to reproduce unless you use the same device and view the same issue (or find a different combination that reproduces the problem)

nickoneill commented 4 years ago

@chadschultz I added this to a new 2.2.0 release - let me know if you see anything small we should include, otherwise I will make a new build for the store.

chadschultz commented 4 years ago

@nickoneill I'm not aware of anything else pressing - I'd say to go ahead and publish.

nickoneill commented 4 years ago

Great, will do. Not a priority for this release but if you want to look into something, #119 came up when I was testing this morning. I assume staying updated with the latest gradle is a good thing on android?

chadschultz commented 4 years ago

Definitely a good idea, much like keeping libraries updated in general. It's not critical though, it won't cause things to fall apart in the near future. When I was setting up the code I noticed a lot that should be done to keep it up to date... moving from the old Android support libraries to AndroidX (which would require changing from Google Analytics to Firebase Analytics on the client side), updating to Gradle yes, and it would be a good idea to use the latest version of all libraries when we can. Beyond that, it's nice to dream of making the project structure a bit cleaner, kotlinifying the codebase, refactoring to a decent architecture pattern (such as MVVM) and adding unit testing/UI testing would be lovely. The good news is, if some of that work was done, I feel like it would be easier for people to contribute to the project. On the other hand, it is a pretty simple app and has gone this long without major bugs. Anyway, although I'm excited by the possibilities, I'm reluctant to commit too much - it would be easy for me to get distracted from other projects, such as my efforts to get a job. This week in particular I'm focusing exclusively on working through one company's application process. In the coming weeks I may or may not make some updates to the 5 Calls app... we'll have to see how well I manage my time.

On Sat, Jun 6, 2020 at 5:11 PM nickoneill notifications@github.com wrote:

Great, will do. Not a priority for this release but if you want to look into something, #119 https://github.com/5calls/android/issues/119 came up when I was testing this morning. I assume staying updated with the latest gradle is a good thing on android?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/5calls/android/issues/117#issuecomment-640124673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI4NPOTTWC536I2B66RPKLRVK5K7ANCNFSM4NVLJRZA .