search

5calls / android

The Android App of 5 Calls
https://play.google.com/store/apps/details?id=org.a5calls.android.a5calls&rdid=org.a5calls.android.a5calls
MIT License
20 stars 8 forks source link

Move from ButterKnife to View Binding #122

Closed chadschultz closed 4 months ago

chadschultz commented 4 years ago

Made a Gradle update. At some point the app really needs to be migrated to AndroidX, but that will be tricky because of analytics. Removed ButterKnife; using View Binding instead. ButterKnife was useful in the past, but now "Attention: This tool is now deprecated. Please switch to view binding." https://github.com/JakeWharton/butterknife Lots of changes, but they're generally pretty rote. I did a little bit of formatting cleanup and fixing warnings along the way, but not much, in order to keep the changeset relatively simple. I also tried to impose more consistency in view names.

Please test carefully; this is all relatively basic stuff, but if I happened to accidentally switch two view references around or something dumb like that, there could be weird behavior.

nickoneill commented 4 years ago

This looks great @chadschultz, thanks!

What are some of the things we should watch out for when testing this? App flows that might go to the wrong screens? Buttons that take incorrect actions?

chadschultz commented 4 years ago

I'd test all UI use cases. Make sure the graph looks right, make sure the correct UI element changes when you push a button, make sure text views are formatted the way they're supposed to be, that kind of thing.

On Sat, Aug 22, 2020, 11:41 AM nickoneill notifications@github.com wrote:

This looks great @chadschultz https://github.com/chadschultz, thanks!

What are some of the things we should watch out for when testing this? App flows that might go to the wrong screens? Buttons that take incorrect actions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/5calls/android/pull/122#issuecomment-678662841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI4NPPZT2JF3ZIATEUNORTSB7YMBANCNFSM4QGWF3SA .