NoScript plugin doesn't work on Firefox 42

[ghost]

The NoScript plugin produce following Error on FF 42:

Sourcing file: /home/philipp/.pentadactyl/plugins/noscript-dev.js:291: TypeError: calling a builtin Set constructor without new is forbidden

[wshanks]

Pretty much all of the plugins hosted on 5digits.org have been broken since Firefox 36 (see #23). I would guess that is the issue here (related to breaking changes that Firefox made back then to how array iterators worked), unless the plugin was working for you in Firefox 41?

[ghost]

[2015-11-21 05:51] willsALMANJ notifications@github.com

unless the plugin was working for you in Firefox 41?

It was working with Firefox 41.

[wichtounet]

I personnally have no issue on FF 42 with Noscript and Pentadactyl

[wshanks]

Note: we are talking about the NoScript Pentadactyl plugin from 5digits.org, not the NoScript Firefox add-on (the Pentadactyl plugin provides bindings for the NoScript Firefox add-on).

[troyp]

Pretty much all of the plugins hosted on 5digits.org have been broken since Firefox 36

Actually, a number of the plugins seem to have been updated in the last year or so. (Although some of them — those with minor changes like E4X removal — haven't raised their version number.)

[wshanks]

Hmm, it seems like the hg repo for 5digits.org is not available any more to check the changelog of the plugins. js-completion at least is still broken. I thought I used a couple others that were broken, but it seems like they are all third party plugins.

Regarding the NoScript plugin, going by the Developer Notes for Firefox 42, I would guess that the problem is related to the change that Set() without new now gives a TypeError. The plugin uses some custom constructs from Pentadactyl (namely calls like get set() RealSet(...) where RealSet is the normal Set() class) that I am having trouble deciphering the purpose of.

[wshanks]

I still don't fully understand the get set() RealSet(...) syntax, but just adding new in front of each instance of RealSet seems to fix the plugin. You can use https://gist.github.com/willsALMANJ/accc083077f6996de7f8 if you don't want to do that yourself.

[ghost]

Thanks, this works.

Can you bring this upstream, or shall I write a mail to the Author?

[xrchz]

:+1:

[wshanks]

Well, this plugin file is not in this dactyl repo, but its author is @kmaglione (one of the owners of this repo) and I don't think the plugin is associated with any other public bug tracker, so maybe it's best to just leave this issue open for now and hope he updates the file on 5digits.org.

[wshanks]

The 5digits.org plugins have now been added to this repo. https://github.com/5digits/dactyl/commit/174f4ec6362e56b8693db92e022fac5848b80443 should fix this issue.

[polyzen]

@satan1st, is this resolved for you?

[ghost]

[2016-05-01 05:49] "Daniel M. Capella" notifications@github.com

@satan1st, is this resolved for you?

Yes

[polyzen]

@satan1st, please close this when you get the chance.