search

5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
470 stars 98 forks source link

Pendatactyl ReferenceError on Firefox 44.0a2 #108

Closed veeven closed 8 years ago

veeven commented 8 years ago

Pentadactyl throwing the following error on the console on Firefox 44.0a2. And, pentadactyl commands do not work.

pentadactyl-1 2pre 20151206_error-on-firefox44 0a2

I think the error is due to Breaking changes in let and const in Firefox Nightly 44.

veeven commented 8 years ago

Here is the text from console:

pentadactyl: [Begin base]
pentadactyl: Loading base: ReferenceError: can't access lexical declaration `Iter' before initialization

pentadactyl: bootstrap: ReferenceError: can't access lexical declaration `Iter' before initialization
Class@resource://dactyl/bootstrap.jsm -> resource://dactyl/base.jsm:909:1
@resource://dactyl/bootstrap.jsm -> resource://dactyl/base.jsm:1271:17
loadSubScript@resource://dactyl/bootstrap.jsm:26:12
wshanks commented 8 years ago

I didn't test them individually but either bc9eb79fb310dac1ea8dd304bac4db996c51e6d8 or 65725c95164c6da1fe5bedbeafa651c06d08b72e fixed this issue.

veeven commented 8 years ago

The ReferenceError is no longer thrown with latest code.