search

5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
470 stars 98 forks source link

recent changes cause keyboard shortcut not working on github #118

Closed hrzhu closed 8 years ago

hrzhu commented 8 years ago

steps to reproduce: go to https://github.com/5digits/dactyl, type o, nothing happens, O works. I don't know which specific commit introduce this but reverting to a19a865 the problem is gone.

prmtl commented 8 years ago

+1 here. On the newest build keys like 't', 'o' do not work on Github. They also do not work on Google as search input is always having focus.

jonlorusso commented 8 years ago

+1

~~Not sure if this is related or a separate issue: type 't' (for :tabnew), try typing 'j'. does not work. Capital J does work however. Very odd.~~

Also, in slack (for instance), <Escape> does not exit -- INSERT -- mode. Again, not sure if this is related or a fully separate issue. Edit: This is a separate issue, described here.

timokau commented 8 years ago

Same problem with reddit (with Reddit Enhancement Suite) Probably because reddit and github define their own keyboard shortcuts and pentadactyl doesn't intercept them correctly.

ghost commented 8 years ago

@jonlorusso you have a binding for jj -> escape, right? #116

jonlorusso commented 8 years ago

@rbtwrrr

Close:

cmap jk <Escape>

I'll strikeout that section of my comment above.

jbylsma commented 8 years ago

I believe these issues are all from some PassThrough changes in 28fe4af. I created a pull request #124 that I think should fix it. Can you please test?

wasamasa commented 8 years ago

@jbylsma Thanks, your changes fixed it for me.

jbylsma commented 8 years ago

This was fixed with 4904fb5 and can be closed.