search

5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
468 stars 98 forks source link

Passthrough is too eager since "Improve the efficiency/bugginess of abbrev mappings." #121

Closed woutershep closed 8 years ago

woutershep commented 8 years ago

On http://slashdot.org a lot of keys don't work in command mode and are instead passed through to the page. I've bisected it to:

28fe4afc4ea21d154aa4066a12cc92952e480e48 is the first bad commit commit 28fe4afc4ea21d154aa4066a12cc92952e480e48 Author: Kris Maglione maglione.k@gmail.com Date: Sun Dec 20 20:35:23 2015 -0800

Improve the efficiency/bugginess of abbrev mappings.

The most easy to test is the 'd' key, which instead of closing the window as expected, ends up collapsing the news items instead.

Possibly related bugs are #118 and #119

Oh and if it matters ive been using firefox 43.0

jbylsma commented 8 years ago

I tracked down the same commit and created PR #124 that I think fixes it. I'm pretty sure #118 and #119 are the same issue. Can you please test?

woutershep commented 8 years ago

Fixed by https://github.com/5digits/dactyl/commit/4904fb5bff72e0d45fea353372ccf9c3061722f8