5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
468 stars 98 forks source link

Passthrough fix #124

Closed jbylsma closed 8 years ago

jbylsma commented 8 years ago

I was having passthrough issues like issues #118, #119, and #121. I bisected commits backed and narrowed the problem down to 28fe4af, where keyup's pass assignment was converted to a function. I found two issues:

Although I haven't done any Firefox plugin development before and I didn't quite following the abstraction changes in Pentadactyl, I'm fairly confident that the logic changes I've made are correct. I've A/Bed against previous successful commits and util.dumped a lot of vars to make sure things seem right.

lichray commented 8 years ago

Confirmed to work with github and google search.

hrzhu commented 8 years ago

Tried your branch, it fixed the pass-through issue on github.

PTNobel commented 8 years ago

Fixed GitHub, Google, and Firefox's built-in PDF viewer (I think it's named pdf.js) for me.

woutershep commented 8 years ago

Can confirm that it fixes #121 for me. Haven't noticed any negative side-effects at least. I have switched from a local version where i had 28fe4af reverted, to this pr merged into master, and couldn't tell any difference.

deewakar commented 8 years ago

Fixes Reddit ( Reddit Enhancement Suite) too.

abazishkumbin commented 8 years ago

Are there any plans to merge this?

arxanas commented 8 years ago

+1, also suffering from this.

jbylsma commented 8 years ago

The commit 4904fb5bff72e0d45fea353372ccf9c3061722f8, which was recently applied to master, applies the same logic as this pull request, so I'll go ahead and close this. Thank you everyone for testing!