search

5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
468 stars 98 forks source link

:tabopen does not work with Firefox 46 #153

Closed thisfred closed 8 years ago

thisfred commented 8 years ago

When I type

:tabopen some string

I get the following error:

resource://dactyl/util.jsm: 1583: TypeError: can't assign to properties of (new String(" ")): not an object

and nothing else happens.

thisfred commented 8 years ago

When I pass a url, it does seem to work.

thisfred commented 8 years ago

But previously, any other string would result in a google search for that string, rather than a javascript error.

polyzen commented 8 years ago

This also seems to occur with url's lacking the scheme (eg. https://).

Edit: Same error as in #152

mariusor commented 8 years ago

This gets fixed by https://github.com/5digits/dactyl/pull/151

krompus commented 8 years ago

Good to know #151 fixes it.

I tried updating to the latest nightly, and it tells me that it's incompatible. Any idea if there's a workaround for this? I remember toggling xpinstall.signatures.required to false in about:config for previous versions to allow "incompatible" extensions to install anyways. It's still false; perhaps they've changed the method?

EDIT: I uninstalled Penta completely, and then installed the AUR package pentadactyl-git. It's working again. :)

polyzen commented 8 years ago

@thisfred, the fix is in master, this can be closed. :)

thisfred commented 8 years ago

sorry, closed now :)