search

5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
468 stars 98 forks source link

NoScript plugin don't work on FF46 #157

Open ghost opened 8 years ago

ghost commented 8 years ago

On FF46 noscript plugin produces folloing error: Sourcing file: ~/.pentadactyl/plugins/noscript.js:246: SyntaxError: missing ] after element list

I have reimplemented the get() function a little patch (http://ix.io/yVV), I stack now with following error: Sourcing file: ~/.pentadactyl/plugins/noscript.js:1: SyntaxError: redeclaration of let groupProto

My patch isn't realy good, I just wanted it bring to work again

rdrr commented 8 years ago

I seem to be having the same problem with a stylish.js plugin (https://github.com/ervandew/vimperator-plugins/tree/master/plugin). It worked great until FF46. I am now getting the same "missing ] after element list" sourcing error and it no longer appears as a command.

futuro commented 8 years ago

This is because the Array Comprehension syntax changed in FF 46. Where before you would do, say, [X for (Y in Z)] now you do [for (Y of Z) Y].

After swapping all of the comprehension calls around, I'm getting an error missing variable name on line 314, so I'm investigating that. It seems to be an issue with destructuring assignment in array comprehensions, but we'll find out.

For more information on comprehensions in FF47+, see Array comprehensions and Generator comprehensions