5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
467 stars 98 forks source link

Change regex to match all possible function string representations #210

Closed wshanks closed 4 years ago

wshanks commented 7 years ago

In Firefox 54, it is possible for a function defined inside of an object like {foo(arg) {alert(arg)}} to have string representation foo(arg) {alert(arg)} instead of function foo(arg) {alert(arg)}. This was the case for the init method of Iter on line 1832 of common/base.jsm.

This fixes #209 for me. I'm not 100% sure that there aren't other side effects. With this Pentadactyl loads and the command line works. You can use :open to open URL's. However, other features seem to be broken like hints.