5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
467 stars 98 forks source link

Firefox 55(.0.3) crashes with Pentadactyl installed. #216

Open jonlorusso opened 6 years ago

jonlorusso commented 6 years ago

Don't know how to reproduce this issue. It takes several minutes for it to happen on average.

dnnr commented 6 years ago

I see the same issue. It happens reproducibly for specific keyboard inputs.

rdrr commented 6 years ago

Can you post some of the key presses that are causing it to crash for you? I've been running for a few days and haven't had a crash yet.

dnnr commented 6 years ago

Pressing return does the trick, reproducibily. I haven't verified that on a clean profile, though. I'm also not expecting much to come out of this report, given the project is basically dead, except for the few of us clinging to it while it still (sort of) works.

egolus commented 6 years ago

gd crashes for me

edit: actually a lot of g+<key> combinations lead to a crash

dermorz commented 6 years ago

<CR> in normal mode also does the trick (no field selected).

/edit: Even if you map <CR> to any key.

wshanks commented 6 years ago

This crashing is due to a bug in Firefox 55. See https://bugzilla.mozilla.org/show_bug.cgi?id=1397711 and https://github.com/willsALMANJ/pentadactyl-signed/issues/4. The bug is fixed in the current beta release of Firefox (version 56).

krompus commented 6 years ago

@willsALMANJ oh, thank goodness.

I was hoping it's not finally time to migrate. Starting the feel like I'm on a sinking ship though, haha.

Unrelated, but I'd rather not open another issue just for this question: how shall I keep Penta up to date going forward? Basically just make sure it's signed? Thanks. :)

wshanks commented 6 years ago

I'm not sure how the signing is going to work once 57 comes out and legacy addons are no longer allowed. I thought I saw that they would stop signing legacy addons at some point. If your primary interest is in using Pentadactyl and not in new Firefox features, you can get a little more life out of it by using Firefox 52 ESR which is officially supported until July 2018. Also, you might be able to use Pentadactyl with Firefox 59 Nightly when 57 comes out. At least, there are preferences in Nightly for turning off the signing requirement and for allowing legacy addons to be installed. However, it was hard enough keeping Pentadactyl working when XUL addons were supported. Once they are no longer supported, I would guess the internals of Firefox that Pentadactyl relies on will change more rapidly.

krompus commented 6 years ago

Thanks for the heads up. I'm really not looking forward to this. As a fellow Pentaddict, what are your plans? ESR?

wshanks commented 6 years ago

For now, I use Saka Key. It has issues, but it worked better for me than Vimium-FF the last time I tried it. The developer of Saka Key is responsive and plans to add more features. Neither of those two allows mapping keys to arbitrary code right now, which I want. Longer term I am watching the "Better keyboard support" ticket on Bugzilla and hoping it allows for something closer to Pentadactyl. If it ever goes anywhere, then tridactyl might be interesting. I want to stay with Firefox for now but other people have talked about switching to another browser that has vim features built in like QuteBrowser.

Below I am putting the links to the projects I mentioned and some other issues that have discussed this topic. I recommend posting to one of the other issues rather than here so as not to spam the people subscribed to this issue.

Other projects https://addons.mozilla.org/en-US/firefox/addon/vimium-ff/ https://addons.mozilla.org/en-US/firefox/addon/saka-key/ https://github.com/cmcaine/tridactyl https://github.com/qutebrowser/qutebrowser

Better support in Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1215061 https://github.com/cmcaine/keyboard-api https://github.com/Koushien/keyboard-shortcut-api

Previous discussions https://github.com/5digits/dactyl/issues/99 https://github.com/vimperator/vimperator-labs/issues/705 https://github.com/akhodakivskiy/VimFx/issues/860 https://github.com/willsALMANJ/pentadactyl-signed/issues/3