5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
470 stars 98 forks source link

Tab Mix Plus Multi-row tab broken with Pendatactyl #73

Open Massimo-B opened 9 years ago

Massimo-B commented 9 years ago

Where are all the issue from the previous issue tracker?

There was: https://code.google.com/p/dactyl/issues/detail?id=1211

Restarting Pentadactyl with TabMixPlus (TMP) enabled and multi-row tabs breaks the multi-rows to one row until FF restart.

eboth commented 9 years ago

There are even worse incompatibilities with Tab Mix Plus (like a dead address bar that is neither updated nor can be used to navigate to a URL), so I reluctantly gave up on it and haven't really missed it since.

hetisthijs commented 9 years ago

I have been using Pentadactyl for a long time with Tab Mix Plus. I made this fix years ago:

edit /chrome/common/skin/dactyl.css from the xpi (or inside your git code) remove the following lines:

#TabsToolbar .tab-icon-image, .tab-throbber { -moz-box-ordinal-group: 10; }
[dactyl|highlight~=tab-number]              { -moz-box-ordinal-group: 20; }
.tab-text, .tab-label, .tab-close-button    { -moz-box-ordinal-group: 50; }

and:

/* Fix ginormous Australis tabs. */
[dactyl-australis=true] :-moz-any(xul|tab.tabbrowser-tab, .tabs-newtab-button)
        .tab-background > * {
    min-height: 24px !important;
    max-height: 24px !important;
}

[dactyl-australis=true] :-moz-any(xul|tab.tabbrowser-tab, .tabs-newtab-button)
    .tab-background > :-moz-any(.tab-background-start, .tab-background-end)::after {
    background-size: 30px 24px !important;
    max-height: 24px !important;
    min-height: 24px !important;
}

[dactyl-australis=true] .tabbrowser-tabs {
    min-height: 0 !important;
    max-height: 24px !important;
}

Multi-rows should work now. Let me know if it's working.

Massimo-B commented 8 years ago

Is this really fixed? I build Penta from the current git sources, the issue is still there. However I find only ./common/skin/dactyl.css in the repo, and that file still has the lines you said to remove.

hetisthijs commented 8 years ago

I made a pull request for this months ago, but it still isn't approved. So you have to remove the lines manually like I said above. Then it should work.