search

5digits / dactyl

Pentadactyl and other related Gecko extensions
Other
470 stars 98 forks source link

<Pass> in input mode mappings works improperly #98

Open d-g opened 8 years ago

d-g commented 8 years ago

Since Pentadactyl’s input and text modes are broken with regard to non-ASCII letters (they were always been) and all I need besides ability to start an external editor is several GNU Readline-ish keybindings (in particular <C-w> for killing last word) I tried to pass these keys to Iceweasel to allow properly configured GTK handle them.

It works correctly when I press <C-v><C-w>. However, either of the following mappings:

map -modes input <C-w> -builtin <Pass>
map -modes input <C-w> -builtin <C-v><C-w>

makes <C-w> to be passed to browser as if focus is outside if an input field / textarea, so that instead of killing a word it closes current tab.

d-g commented 8 years ago

The obvious workaround for user who builds Pentadactyl from source is just to comment out lines 1098 ÷ 1134 in common/content/editor.js, but it’s a pity that it could not be done on a level of user configuration.

Maybe I’m missing some possibility to unbind built-in mappings on-the-fly?

NigoroJr commented 8 years ago

I also have GTK key bindings. I have the exact same problem on Firefox 38.6.0 when using map -modes=i. My guess is that -modes input is not working correctly (since <Pass> works for -modes=n), but I haven't spent too much time looking into it.