search

5e-bits / 5e-database

Database for the D&D 5th Edition API
http://dnd5eapi.co/
MIT License
716 stars 353 forks source link

Setup test to verify non-SRD information is not included. #114

Open benjaminapetersen opened 4 years ago

benjaminapetersen commented 4 years ago

I believe Travis-CI will run for free against a github repo. As long as PRs are used rather than direct merge to master, a simple test script could be written to read the JSON files, and validate the items.
For example, load the monsters-SRD.json, loop all the names and verify a hard-coded list of names. If anyone adds additional, tests fail.

bagelbits commented 4 years ago

That sounds like a pretty good idea.

bagelbits commented 4 years ago

@benjaminapetersen Let me know if I can help with this as at all.

benjaminapetersen commented 4 years ago

The main issue here is the need to run some code. Does anyone have strong feelings on language, etc?

bagelbits commented 4 years ago

Not really though I think the scripts that currently exist in this repo are all JS. Though I think they need to be organized and maybe documented.

On Tue, Dec 17, 2019 at 6:36 AM Ben Petersen notifications@github.com wrote:

The main issue here is the need to run some code. Does anyone have strong feelings on language, etc?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/adrpadua/5e-database/issues/114?email_source=notifications&email_token=AACWKWS7M2WTJV5MUUSL2PDQZDPV3A5CNFSM4JMIJEGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHCSGCQ#issuecomment-566567690, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACWKWQLZMTZM3ZFPRXUIM3QZDPV3ANCNFSM4JMIJEGA .

bagelbits commented 4 years ago

@ogregoire or @Alex-frazer Strong feelings on language? I mostly work in Ruby and Node. But for consistency between the languages currently in the DB and API, Node might make the most sense for now?

benjaminapetersen commented 4 years ago

Node is probably the most approachable to the most people.

ogregoire commented 4 years ago

I'm more of a C/C++/Java/Python guy, but any language is good for me as it will be quite easy to implement.

bagelbits commented 4 years ago

I just cut #132 which should lay some of the ground work for some of this. At least the bare minimum of a linter. I can also handle setting up the plumbing for Buildkite so that we can run that. Thought that'll have to wait until ownership gets transferred.

bagelbits commented 4 years ago

Yup. #132 is ready to go and it will also add in Travis CI. I'm also happy to split up the PR, as it's doing quite a bit of stuff.

benjaminapetersen commented 4 years ago

+1

bagelbits commented 4 years ago

@benjaminapetersen Travis CI is now setup.