5fpro / jupiter

2 stars 3 forks source link

projects#show records#index 的資訊 #27

Closed marsz closed 8 years ago

marsz commented 8 years ago

GET /projects/123

GET /projects/123/records

marsz commented 8 years ago

https://github.com/5fpro/jupiter/pull/35

marsz commented 8 years ago

多做的:

marsz commented 8 years ago

@phrase5036 這張票比較多,因為用了一整天的時間,所以要仔細讀完,其中 controller 安全性那邊尤其重要,因為之後很多 controller 都會 under 在 project ,又要同時考量是不是自己的或是 owner ...blabla,等上線後一段時間我們再來套論這邊的細節

phrase5036 commented 8 years ago

@marsz 我仔細的把 commit 翻開來看完了

但是 rpsec 有點怪 https://github.com/5fpro/jupiter/commit/c9787adad57742baff8ee47102a6d69e335a3085#commitcomment-15726535

marsz commented 8 years ago

@phrase5036 已修感謝

phrase5036 commented 8 years ago

thx