5hirish / adam_qas

ADAM - A Question Answering System. Inspired from IBM Watson
http://www.shirishkadam.com/
GNU General Public License v3.0
357 stars 106 forks source link

Fixed bug #22, the upsert request script in plainless was flawed. #24

Closed 5hirish closed 6 years ago

5hirish commented 6 years ago

Fixed fallback when default model not found

Description

Addresses the Issue #22

Types of change

1) Fixed the Upsert GET request, where the painless script had a typo of a comma. 2) Added fallback logic if the language model not found.

Checklist

codecov[bot] commented 6 years ago

Codecov Report

Merging #24 into master will decrease coverage by 0.32%. The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   40.85%   40.53%   -0.33%     
==========================================
  Files          26       26              
  Lines        1383     1394      +11     
  Branches      194      195       +1     
==========================================
  Hits          565      565              
- Misses        788      799      +11     
  Partials       30       30
Impacted Files Coverage Δ
qas/adam.py 0% <0%> (ø) :arrow_up:
qas/esstore/es_operate.py 34.95% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a004a11...2f13cab. Read the comment docs.