search

5hwb / Old-Hangul-Input-Method

Javascript-based IME for typing archaic Korean Hangul letters (e.g. ㅸ, ㅿ, ㅵ) easily
Apache License 2.0
19 stars 6 forks source link

Rising and High Korean tones are not supported #4

Closed ScraperMan2002 closed 2 years ago

ScraperMan2002 commented 2 years ago

You forgot to include the Rising and High Korean tones?〮 and 〯. I however, have solved this little problem of yours.

5hwb commented 2 years ago

I'm aware that archaic Hangul tone marks are currently unsupported for the time being. Nevertheless, feel free to create a pull request that implements them and I'll merge the improvements into this project.

ScraperMan2002 commented 2 years ago

I'm new to Github, so I'm new to pull requests, but I've done what I can here by learning the tutorial.

5hwb commented 2 years ago

Thanks for the pull request - this is admittedly my first time reviewing a pull request too. I've left some comments, feel free to review them and address the issues mentioned.