search

5iver / openHAB-utils

Utilities for use with openHAB
15 stars 7 forks source link

Make use of $OPENHAB_HOME/runtime/bin/client for command execution and directory confirmation #1

Closed dbadia closed 5 years ago

dbadia commented 5 years ago

I see the script assumes we are running on the machine where OH is running, so we can use ../runtime/bin/client instead of ssh to access the karaf console. Also added a check to ensure the script is being run from the addons directory.

5iver commented 5 years ago

I've looked this over and tested it... works great! The only thing that is nagging at me is that I definitely recall being prompted for a password when using the client at some point... but I'm not any more.

This is much easier than having people set their public key to avoid being prompted for a password!

BTW, I successfully tested while running OH as a service and not. I did not test running the script from a rule.

dbadia commented 5 years ago

I didn't even know about the client command until a few days ago. It did seem a bit odd that it didn't prompt for a password - I guess the devs figure if you're on the machine they can just let you in (fine by me). Thanks for testing, I should have mentioned that I tested this on my machine where I have OH running with systemd. Thanks for for your work on the script.