search

5k-mirrors / delve-relic-checklist

Checklist / tracker for Relics in Path of Exile Delve league: https://5k-mirrors.github.io/delve-relic-checklist
1 stars 1 forks source link

File structure #47

Open gomorizsolt opened 6 years ago

gomorizsolt commented 6 years ago

I've submitted this issue in the PoE Dashboard repo, but IMO it's important to talk about here as well. I think we have to create a better file structure, or what do you think?

Kexort commented 6 years ago

As mentioned here: https://reactjs.org/docs/faq-structure.html

don’t spend more than five minutes on choosing a file structure

I think the best course is to follow the "Grouping by features or routes" convention. In this project we doesn't have routes (yet?), so let's group by features.

This is for the 'src' folder. Other than that assets should go to the public folder.

How about this? (This is just a suggestion, you can propose something if you find that better)

I think this project won't grow much larger to cause us problems, but it's a valid concern about the dasboard. If you want to use the same structure for the two projects i'm also ok with it :)

gomorizsolt commented 6 years ago

"Grouping by features or routes" - I like it. I think we can go on this way and will see it.