5k-mirrors / poe-live-search-manager

Desktop tool for Path of Exile for managing live item searches and making instant offers without leaving the game.
168 stars 32 forks source link

Update dependencies, fix reconnection and implement darkmode #192

Closed mfjordvald closed 1 year ago

mfjordvald commented 1 year ago

Apologies for a bit of a wide-ranging PR. I wanted to make some changes for myself and ended up doing a bit of maintenance to remove the deprecation warnings in the console.

The biggest maintenance items here are:

In addition this PR fixes #191 and implements #142 #165

The #191 fix is done by explicitly calling the connect function since simply calling disconnect will not trigger auto-reconnect if the socket already had an abnormal disconnection.

The dark mode feature selects the light/dark Mui palette based on the system preference.

mfjordvald commented 1 year ago

Linting is freaking out since the used babel-eslint package is deprecated, the new @babel/eslint-parser package that replaces it functions correctly but calls out a bunch of the existing code that I didn't touch. I'm guessing that the currenting linting setup simply isn't using the majority of the linting packages it includes.

Happy to work on fixing up the linting but it is probably better done in a different PR as it will touch a lot of files and obscure the more impactful changes.

thisismydesign commented 1 year ago

Thanks a lot for your effort @mfjordvald! I'll review it next week.

thisismydesign commented 1 year ago

@mfjordvald Please merge master, that should enable the CI to run on your PR.