search

5k-mirrors / poe-live-search-manager

Desktop tool for Path of Exile for managing live item searches and making instant offers without leaving the game.
171 stars 32 forks source link

Source code and session data #80

Closed nathanieloon closed 4 years ago

nathanieloon commented 4 years ago

I noticed that with the release of 1.0 you have removed the source code from the repo. Is there somewhere that this can be viewed? Is there a particular reason you've removed it?

Also, what do you do with our session data?

thisismydesign commented 4 years ago

I didn't have enough free time to continue development on my own. Currently, the app is partially developed by paid developers and is slightly coupled to other development work we do. For this reason, at this point, the project is closed sourced. We may consider open sourcing it partially or fully in the future.

The app works with users. The only data we use is for the purpose of authentication. Everything else (searches, session id, settings, etc) are stored locally.

nathanieloon commented 4 years ago

Fair enough, thanks for clarifying. If you end up open sourcing it in the future that would be great, but for now I'm not comfortable using the application given that the session ID provides so much access to my PoE account.

thisismydesign commented 4 years ago

It's unfortunate that the session id is required for running live searches. Perhaps if enough people put in a request at GGG, they would make it available logged-out. If that ever happens I will be more than happy to update the app and remove the session id.

Kexort commented 4 years ago

the session ID provides so much access to my PoE account.

The easy way around this is just create a new account that you use only for the search. I just checked it and you don't even have to verify your e-mail for the live search!