search

5kmrun-bg / fivekmrun-app

A mobile app for 5kmrun.bg
https://5kmrun.bg
3 stars 5 forks source link

Add Profile Badges #112

Closed mystoev closed 9 months ago

mystoev commented 9 months ago

Fixes #97

Add badge to the lower right angle of the profile image. See images below:

max selfie
etabakov commented 9 months ago

UserIDs we can test with: 14, 57, 99, 1469. On the website the badge has as number with how many times the badge is claimed, which might be too much for the profile picture. However, the current behaviour in this PR checks for the last year only, right? The badge might be awarded in one of the previous calendar years.

mystoev commented 9 months ago

UserIDs we can test with: 14, 57, 99, 1469. On the website the badge has as number with how many times the badge is claimed, which might be too much for the profile picture. However, the current behaviour in this PR checks for the last year only, right? The badge might be awarded in one of the previous calendar years.

Yes, it checks only for the current year. I guess that would be enough for now. Later, when we plan to create the badge section, we could elevate that.

etabakov commented 9 months ago

My concern is that some users that have the badge from previous year might be disappointed from not seeing it in their profile. Also, it can have strange behaviours like you have it on 31 dec and then on 1 jan you don't have it anymore. Could we change the logic to be have the badge "any year" instead of "last year only"?

etabakov commented 9 months ago

Looks good to me 👍 It seems we don't have a single runner with MAX Selfie badge won yet or at least I couldn't find one. I don't see any issues with the implementation and MAX officials behaves as expected, so just mentioning to keep an eye on it.