5kmrun-bg / fivekmrun-app

A mobile app for 5kmrun.bg
https://5kmrun.bg
3 stars 5 forks source link

Add Initial Unit Tests #114

Closed mystoev closed 9 months ago

mystoev commented 9 months ago

Add the following libraries:

Add initial tests for a few files in the lib/common folder in order to validate the testing strategy and infrastructure.

mystoev commented 9 months ago

@etabakov I added a few simple tests to validate how we want to test things. Particularly, I added the golden_toolkit library to make snapshot tests. WDYT about having such tests?

etabakov commented 9 months ago

It's a dream come true for me - it will give so much peace of mind when deploying new versions!! I'd lean on @vakrilov to weigh in on the best technical approach as I don't have too much experience with testing frameworks but definitely would like to invest in that.

etabakov commented 9 months ago

It's exciting that we wouldn't have release the buggy version today if we had these tests :D

mystoev commented 9 months ago

Yeah :) Let's add these first, and I can add more PRs with more tests.

Maybe I can add a PR that adds the tests to the CI first... What do you think?

etabakov commented 9 months ago

Yes. Adding to CI first and then adding more tests sounds like the right sequence to me.