search

5monkeys / django-bananas

Django extensions the monkey way
MIT License
66 stars 17 forks source link

Ignore broken self type #62

Closed antonagestam closed 3 years ago

antonagestam commented 3 years ago

This fixes an issue that appears after upgrading djangorestframework-stubs.

See this issue on restframework-stubs: https://github.com/typeddjango/djangorestframework-stubs/issues/132

github-actions[bot] commented 3 years ago

File Coverage Lines Branches Missing
All files 92% 97% 87% :white_check_mark:
__init__.py 83% 100% 67% :x:
models.py 97% 100% 93% :white_check_mark:
url.py 97% 100% 94% :white_check_mark:
admin/extension.py 93% 100% 86% :white_check_mark:
admin/api/i18n.py 90% 80% 100% :white_check_mark: 9
admin/api/mixins.py 69% 75% 63% :x: 70, 78-84, 94, 110, 117-128
admin/api/serializers.py 75% 100% 50% :x:
admin/api/versioning.py 92% 100% 83% :white_check_mark:
admin/api/views.py 99% 99% 100% :white_check_mark: 134
admin/api/schemas/base.py 88% 75% 100% :white_check_mark: 3
admin/api/schemas/yasg.py 89% 96% 82% :white_check_mark: 77, 86, 125-126
drf/fencing.py 87% 95% 80% :white_check_mark: 81-87, 118
management/commands/syncpermissions.py 88% 95% 80% :white_check_mark: 31

Minimum allowed coverage is 85%

Generated by :monkey: cobertura-action against 0e26d2891dbb7a4f983f38589ec6986775d30d02

antonagestam commented 3 years ago

Pushed a different fix. It's very likely that this breaks generic bindings for subclasses that override perform_update(), but unless the situation becomes better upstream I can't see a better fix for now.