classproperty has been moved to django.utils.functional

5monkeys / django-enumfield

Custom Django field for using enumerations of named constants

MIT License

205 stars 46 forks source link

classproperty has been moved to django.utils.functional #63

Closed lamby closed 4 years ago

lamby commented 4 years ago

re. #62

lamby commented 4 years ago

With the release of 3.1, it would be great if this was merged.

jturmel commented 4 years ago

Two things:

This breaks Django older than 3.1
You need to add Django 3.1 to test config

lamby commented 4 years ago

Thanks for the quick review. Updated. :+1:

jturmel commented 4 years ago

You're still failing, you can see the results in Travis at the link below, you should run the tests locally before pushing up.

lamby commented 4 years ago

Sorry for the noise. I can't seem to get mypy working locally, but I've just pushed another update that I think should fix it.. will check after the tests have run. :+1:

lamby commented 4 years ago

The tests are still failing, but it looks like this is due to unrelated reasons:

django_enumfield/enum.py:118: error: Missing return statement

(I do not touch this line.)

lamby commented 4 years ago

Any ideas? :)

lamby commented 4 years ago

I'm still a little stuck I'm afraid; this looks like it is failing due to something unrelated to my commit/change (line 118).

ca-simone-chiorazzo commented 4 years ago

Any news on this? We are stuck updating to Django 3 due to this problem.

lamby commented 4 years ago

Alas, I am still stuck with this seemingly-unrelated test issue. :)

coveralls commented 4 years ago

Coverage increased (+0.01%) to 98.534% when pulling 5e419c168a3f0515d219cb6ce0a8249b738114ee on lamby:issue-62 into a43b87ae59898daf04129c9d15a28b71e08ba589 on 5monkeys:master.

hannseman commented 4 years ago

Thanks for your PR and sorry for the late review! The CI failures you where seeing was totally unrelated to your PR. The issue was that mypy and black have been updated since we last ran CI and in these newer versions some new rules was added which caused failures. I took the liberty to fix these issues directly in this PR. We'll release a new version on PyPI ASAP!

Also, thanks @jturmel for the review!

lamby commented 4 years ago

Yay!

jturmel commented 4 years ago

Great!

On Wed, Sep 2, 2020 at 3:47 PM Chris Lamb notifications@github.com wrote:

Yay!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/5monkeys/django-enumfield/pull/63#issuecomment-685989031, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJHSJNFZYEIJV75LF3R4TSD2VO5ANCNFSM4PU3K7AQ .

lundberg commented 4 years ago

Version 2.0.2 released.