5monkeys / django-enumfield

Custom Django field for using enumerations of named constants
MIT License
205 stars 46 forks source link

disabled field fills wrong initial value #64

Open fboerman opened 4 years ago

fboerman commented 4 years ago

Hi, I have an enumfield that I have disabled as part of a form with disabled=True. however then the validation always validates the field as being wrong.

After some debugging I found this is due to the fact that the value given to clean differs if the field is disabled or not. when it is not disabled it is a string containing a number if it is disabled it is a string containing the string name of the enum option.

I have spend quite some time thinking about a solution myself but cant get it right. Does any of the maintainers have an idea? Thanks in advance!

ghost commented 2 years ago

About a year too late but ... 😅 Did you forget to set the field to required=False? I get an empty string when I disable the field + set required to false (which is intended behavior as far as I can tell.)

The form validates.

Mojken commented 2 years ago

This seems like it shouldn't be open anymore, close it?

fboerman commented 2 years ago

About a year too late but ... sweat_smile Did you forget to set the field to required=False? I get an empty string when I disable the field + set required to false (which is intended behavior as far as I can tell.)

The form validates.

do you mean explicitely setting it instead of leaving it open as the default?

ghost commented 2 years ago

I mean explicitly setting required=False in the form class.