search

5n00p4eg / Drupal-json-schemas

This schemas can be used to validate Drupal 8 yaml files.
GNU General Public License v3.0
8 stars 3 forks source link

Remove suggestions #3

Closed Chi-teck closed 5 years ago

Chi-teck commented 5 years ago

Turns out PhpStorm already provides autocomplete suggestions for service tags likely with the help of Symfony plugin. Maintaining enumerations for other properties has a little use as they are not widely used. Also the way they are currently implemented is rather tricky. See https://github.com/json-schema-org/json-schema-spec/issues/751 for details.

5n00p4eg commented 5 years ago

Yes, this make sense. Another point that this values is not only possible values. For example contrib & custom modules can provide new service tags.

Maybe we can provide some example values (like most popular) ?

Chi-teck commented 5 years ago

Maybe we can provide some example values (like most popular)?

We can, however PhpStorm does not make use of examples keyword for autocomplete suggestions.

And again, for service tags autocompletion works fine without JSON schema.