aicynide
commented
2 months ago @5rahim
Closed aicynide closed 2 months ago
aicynide
commented
2 months ago @5rahim
5rahim
commented
2 months ago This issue doesn't occur in any of the published binaries, even the Linux one. This is an issue with the web framework package not supporting the Termux environment or something else, idk. Not on my end.
aicynide
commented
2 months ago Since v2.1.1 this error is happening, v2.1.0 works just fine in android. Was anything changed in seanime react code? v2.1.0 link https://github.com/termux/termux-packages/actions/runs/10779296063
5rahim
commented
2 months ago Nothing in the build process was changed
aicynide
commented
2 months ago @5rahim check the buildscript; https://github.com/termux/termux-packages/blob/master/packages/seanime/build.sh ; you are the one able to fix it
5rahim
commented
2 months ago If like you said 2.1.0 works then there's nothing to fix there since the build process did not change. Try and build 2.1.1 yourself for termux, if the error doesn't occur then this is an issue with the termux release.
SonaliBendre
commented
2 months ago @5rahim react build has some issue
> seanime-web@0.1.0 build
> next build
Attention: Next.js now collects completely anonymous telemetry regarding usage.
This information is used to shape Next.js' roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://nextjs.org/telemetry
▲ Next.js 14.2.7
Creating an optimized production build ...
Browserslist: caniuse-lite is outdated. Please run:
npx update-browserslist-db@latest
Why you should do it regularly: https://github.com/browserslist/update-db#readme
Browserslist: caniuse-lite is outdated. Please run:
npx update-browserslist-db@latest
Why you should do it regularly: https://github.com/browserslist/update-db#readme
✓ Compiled successfully
Linting and checking validity of types ...Failed to compile.
./src/api/hooks/anime_entries.hooks.ts:11:24
Type error: '"@/api/generated/types"' has no exported member named 'Anime_AnimeEntry'. Did you mean 'Anime_Entry'?
9 | } from "@/api/generated/endpoint.types"
10 | import { API_ENDPOINTS } from "@/api/generated/endpoints"
> 11 | import { AL_BaseAnime, Anime_AnimeEntry, Anime_LocalFile, Anime_MissingEpisodes, Nullish } from "@/api/generated/types"
| ^
12 | import { useQueryClient } from "@tanstack/react-query"
13 | import { toast } from "sonner"
14 |wtf!!😂😂😂
SonaliBendre
commented
2 months ago wtf seanime is building even after i delete many files in web directory
i ran and getting the same error which is obvious
You have to write a script to detect all web-ui assets properly and throw error if any single file missing
5rahim
commented
2 months ago You need to build from the latest tagged commit because obviously the later commits are work in progress.
aicynide
commented
2 months ago You need to build from the latest tagged commit because obviously the later commits are work in progress.
Its latest tagged commit https://github.com/termux/termux-packages/blob/master/packages/seanime/build.sh#L5-L7
What i'm saying is build system need to fix because it builds the app even when some web-ui files are missing
5rahim
commented
2 months ago You need to build from the latest tagged commit because obviously the later commits are work in progress.
I'm talking about your local build
build system need to fix because it builds the app even when some web-ui files are missing
You can do that yourself by checking that the web folder is not empty before building the server
SonaliBendre
commented
2 months ago build system need to fix because it builds the app even when some web-ui files are missing
You can do that yourself by checking that the web folder is not empty before building the server
even if 1 single .html file is missing its have this error
SonaliBendre
commented
2 months ago build system need to fix because it builds the app even when some web-ui files are missing
You can do that yourself by checking that the web folder is not empty before building the server
how exactly will i be able to check it in Github Actions? https://github.com/termux/termux-packages/actions/runs/10819176659/job/30016456462
SonaliBendre
commented
2 months ago do you use any special kind of Github Actions?
5rahim
commented
2 months ago Just ls the web folder and check that it's not empty. The next.js build won't just simply miss some files so there's no need to check individual files.
5rahim
commented
2 months ago Closing as this is not a bug related to the current releases.
SonaliBendre
commented
2 months ago Just
lsthe web folder and check that it's not empty. The next.js build won't just simply miss some files so there's no need to check individual files.
is your Github Actions can be used interactive mode? well, the Github Actions that termux and probably many other projects use don't let to do this
termux package policy don't accept PR for uunnecassary thing like "ls"
5rahim
commented
2 months ago I can't help you with that, there might be an issue with the termux build process failing to adequately copy the web files. Also, I don't check the web folder in my github actions because I don't see the need.
SonaliBendre
commented
2 months ago Closing as this is not a bug related to the current releases.
it is https://github.com/5rahim/seanime/issues/124#issuecomment-2351993901 https://github.com/5rahim/seanime/issues/124#issuecomment-2352036221
5rahim
commented
2 months ago it is https://github.com/5rahim/seanime/issues/124#issuecomment-2351993901
It's not, you tried to build from an untagged commit which was a work in progress with bugs.
SonaliBendre
commented
2 months ago it is #124 (comment)
It's not, you tried to build from an untagged commit which was a work in progress with bugs.
clearly mentioned in the issue report that the bug is regarding termux and not my local build
SonaliBendre
commented
2 months ago Also, I don't check the web folder in my github actions because I don't see the need.
understandable https://repology.org/project/seanime/versions
5rahim
commented
2 months ago clearly mentioned in the issue report that the bug is regarding termux and not my local build
5rahim
commented
2 months ago You're copying the out directory itself under web, instead of its content.
It should be cp -r $TERMUX_PKG_HOSTBUILD_DIR/seanime-web/out/* $TERMUX_PKG_SRCDIR/web/
Checklist
Bug Severity
Usability is affected
Bug Area
UI / Web Interface
Bug Description / Steps to Reproduce
pkg ins seanimeExpected Behavior
No response
Screenshots
No response
Logs
Debugging Checklist
App Version
v2.1.1
Operating System
Linux