search

5rahim / seanime

Free and open-source media server for anime and manga that includes library scanning, downloading, transcoding, torrent streaming, and more.
https://seanime.rahim.app
MIT License
312 stars 18 forks source link

bug: Specials don't open in external player #139

Open sin3point14 opened 3 days ago

sin3point14 commented 3 days ago

Checklist

Bug Severity

Usability is affected

Bug Area

UI / Web Interface

Bug Description / Steps to Reproduce

I downloaded an OVA via Seanime UI and it is properly detected: image I set seanime to open everything in external media player, however It doesn't work when I try to click the play button. Other series work

Expected Behavior

It should open the EP in my vlc

Screenshots

No response

Logs

When I click the play button, I can see this in console logs:

[PLAY_MEDIA]:  Playing media file /data/seanime/library/Re Zero kara Hajimeru Isekai Seikatsu OVAs/[BlurayDesuYo] ReZero kara Hajimeru Isekai Seikatsu - Memory Snow OVA (BD 1920x1080 10bit FLAC) [5BA32318].mkv [page-a79e6546fef4e74f.js:1:85832]
[PLAY_MEDIA]:  Opening media file in external player vlc://{url} /data/seanime/library/Re Zero kara Hajimeru Isekai Seikatsu OVAs/[BlurayDesuYo] ReZero kara Hajimeru Isekai Seikatsu - Memory Snow OVA (BD 1920x1080 10bit FLAC) [5BA32318].mkv [page-a79e6546fef4e74f.js:1:85832]
[MEDIALINKS]:  Filepath /data/seanime/library/Re Zero kara Hajimeru Isekai Seikatsu OVAs/[BlurayDesuYo] ReZero kara Hajimeru Isekai Seikatsu - Memory Snow OVA (BD 1920x1080 10bit FLAC) [5BA32318].mkv Episode 
Object { type: "special", displayTitle: "Special 1", episodeTitle: "", episodeNumber: 1, absoluteEpisodeNumber: 0, progressNumber: 0, localFile: {…}, isDownloaded: true, episodeMetadata: {…}, fileMetadata: {…}, … }
​[REDACTED]
[page-a79e6546fef4e74f.js:1:85832]
[MEDIALINKS]:  Episode progress number is not set. [page-a79e6546fef4e74f.js:1:86265]

Since I can't get manage to copy the logged object properly, I'm attaching screenshots for its content image image

Also, for reference, kami no tou works and here are its logs:

[PLAY_MEDIA]:  Playing media file /data/seanime/library/Kami no Tou Tower of God - Ouji no Kikan/[Erai-raws] Kami no Tou - Ouji no Kikan - 10 [1080p][Multiple Subtitle][067E574F].mkv page-a79e6546fef4e74f.js:1:85832
[PLAY_MEDIA]:  Opening media file in external player vlc://{url} /data/seanime/library/Kami no Tou Tower of God - Ouji no Kikan/[Erai-raws] Kami no Tou - Ouji no Kikan - 10 [1080p][Multiple Subtitle][067E574F].mkv page-a79e6546fef4e74f.js:1:85832
[MEDIALINKS]:  Filepath /data/seanime/library/Kami no Tou Tower of God - Ouji no Kikan/[Erai-raws] Kami no Tou - Ouji no Kikan - 10 [1080p][Multiple Subtitle][067E574F].mkv Episode 
Object { type: "main", displayTitle: "Episode 10", episodeTitle: "The Hand of Arlen", episodeNumber: 10, aniDBEpisode: "10", absoluteEpisodeNumber: 23, progressNumber: 10, localFile: {…}, isDownloaded: true, episodeMetadata: {…}, … }
page-a79e6546fef4e74f.js:1:85832
[MEDIALINKS]:  Opening external player vlc://{url} URL http://192.168.1.69:43211/api/v1/mediastream/file/%2Fdata%2Fseanime%2Flibrary%2FKami%20no%20Tou%20Tower%20of%20God%20-%20Ouji%20no%20Kikan%2F%5BErai-raws%5D%20Kami%20no%20Tou%20-%20Ouji%20no%20Kikan%20-%2010%20%5B1080p%5D%5BMultiple%20Subtitle%5D%5B067E574F%5D.mkv page-a79e6546fef4e74f.js:1:85832

we can see that Opening external player is missing in the re zero case

Debugging Checklist

App Version

v2.1.1

Operating System

Windows

5rahim commented 3 days ago

Update the file's metadata from special to main. It's indeed a bug but for AniList OVA/ONA/Special entries like this one, the files should have the main type so progress can be recorded.