search

5um17 / wp-extended-search

Extend default search to search in selected post meta, taxonomies, post types and all authors.
https://www.secretsofgeeks.com/2014/09/wordpress-search-tags-and-categories.html
GNU General Public License v3.0
20 stars 4 forks source link

Add missing text-domain #8

Closed alexclassroom closed 2 years ago

alexclassroom commented 2 years ago

Add these missing text-domain let related strings display correctly.

5um17 commented 2 years ago

Hi,

Thanks for the PR! I found these strings left without domain deliberately, So these strings can be translated using WP translation file. e.g. Search … However, there is one string Setting Name: that should be adjusted as no translation exist for this in WP core.

Could you please adjust the PR?

Thanks

alexclassroom commented 2 years ago

If NOT adding these missing text-domain, related UI strings can't be displayed correctly. Missing-Text-Domain I also found some strings can be localized, will submit new PR.

alexclassroom commented 2 years ago

If there are strings in your plugin that are also used in WordPress core (e.g. ‘Settings’), you should still add your own text domain to them, otherwise they’ll become untranslated if the core string changes (which happens). Please refer the following link: https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#add-text-domain-to-strings

5um17 commented 2 years ago

Yes I know that but the reason is, it is exact copy of core code to keep the same default output. I have to keep the sync of strings if something changes. Still, I see this is standard so we have to follow.

I also found the placeholder strings has issue, those are not translated not because of missing domain but because of early loading of strings. That should be fixed with plugin text domain and I will test and adjust the code if needed.

Thank you very much for your contribution!