Add Python 3.12 Support, Drop Python 3.7

5yutan5 / PyQtDarkTheme

A flat dark theme for PySide and PyQt.

https://pyqtdarktheme.readthedocs.io

MIT License

545 stars 84 forks source link

Add Python 3.12 Support, Drop Python 3.7 #253

Open woopelderly opened 10 months ago

woopelderly commented 10 months ago

fix #252

Update to support Python 3.12. To do this I also had to update pre-commit from 2.20 to 3.5 because of packaging methods that were removed in Python 3.12; specifically Python 3.12 removed the deprecated ImpImporter from pgkutil.
Drop Python 3.7 support because pre-commit 3.5 does not support Python 3.7.
The poetry.lock file was regenerated from within the Python 3.12 virtual environment.

woopelderly commented 10 months ago

pre-commit.ci autofix

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (96eb7e3) 97.12% compared to head (bbcf4d5) 96.92%.

:exclamation: Current head bbcf4d5 differs from pull request most recent head dcab630. Consider uploading reports for the commit dcab630 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #253 +/- ## ========================================== - Coverage 97.12% 96.92% -0.21% ========================================== Files 42 42 Lines 1498 1498 ========================================== - Hits 1455 1452 -3 - Misses 43 46 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kyleboyle commented 4 months ago

Is this repository / project dead? Is there a replacement project?

fgervais commented 3 months ago

This branch works well on my side.

mak448a commented 1 month ago

Is this repository / project dead? Is there a replacement project?

Someone made one: https://github.com/henriquegemignani/PyQtDarkTheme. The issues tab isn't open though.

JWCook commented 1 month ago

Hi @henriquegemignani, I see you included this PR in your fork and published it on PyPI. Are you interested in maintaining that fork, and accepting issues and PRs? It seems like there are others here (including myself) who are willing to help keep this going.

henriquegemignani commented 1 month ago

If you open a PR I'm ok with merging and releasing, but I don't plan on doing more than maintenance that lets me keep upgrading PySide and Python.

JWCook commented 1 month ago

That's fair. Thanks for the reply!

mak448a commented 1 month ago

@henriquegemignani Could you enable issues on your repo?

henriquegemignani commented 1 month ago

@mak448a Sure, but I don't really see an use.