5zig-reborn / The-5zig-Mod

All-in-one modification for Minecraft 1.8.9-1.15.2
https://5zigreborn.eu
GNU General Public License v3.0
110 stars 13 forks source link

Player counter module counts everything #117

Closed L0usy closed 3 years ago

L0usy commented 3 years ago

Describe the bug Not sure if this is a bug or if it's intentional, but the player counter will just get everything in your Tab, and display that as the number of players.

To Reproduce Steps to reproduce the behavior:

  1. Log into server (tested on Hypixel and Hive) with the player counter module.
  2. Hit Tab
  3. If the Tab displays NPC's (Hive lobbies) or if it's completely custom (Hypixel Skyblock) then everything under it will be counted as a player.

Expected behavior Everything in Tab will be counted as a player, even if they're not. You can see in Hypixel Skyblock with the custom Tab that displays account info and stuff, those are being counted as well. And the player count is showing as 153.

Screenshots Hypixel Skyblock (or I think any server with a custom Tab): https://imgur.com/a/27zNNKj Hive (or I think any server that shows NPC's): https://imgur.com/a/wOUowKR

Desktop

Additional context Username: Lou5y Version 1.8.9

i-bug-you[bot] commented 3 years ago

Thank you for opening this bug report. A member of the testing group will try to reproduce it as soon as possible. @zortax, @U5B, @Motschen

roccodev commented 3 years ago

Neither a bug, nor intentional. We simply can't distinguish (or we'd have to include workarounds for every server) these "fake" players, without resorting to only counting the players within the user's range.

L0usy commented 3 years ago

Alright, thanks for responding.